Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15746 )
Change subject: IMPALA-9631: Import HLL functionality from DataSketches ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h File be/src/thirdparty/datasketches/MurmurHash3.h: http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@29 PS3, Line 29: #define FORCE_INLINE __forceinline tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@33 PS3, Line 33: #define ROTL32(x,y) _rotl(x,y) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@34 PS3, Line 34: #define ROTL64(x,y) _rotl64(x,y) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@44 PS3, Line 44: #define FORCE_INLINE inline __attribute__((always_inline)) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@56 PS3, Line 56: #define ROTL32(x,y) rotl32(x,y) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@57 PS3, Line 57: #define ROTL64(x,y) rotl64(x,y) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@97 PS3, Line 97: FORCE_INLINE void MurmurHash3_x64_128(const void* key, int lenBytes, uint64_t seed, HashState& out) { line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/15746/3/be/src/thirdparty/datasketches/MurmurHash3.h@108 PS3, Line 108: const int nblocks = lenBytes >> 4; // bytes / 16 line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/15746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ca8e77dcbb6b6c3b1e3bca7ab57cb7d3c018bbf Gerrit-Change-Number: 15746 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Apr 2020 15:14:55 +0000 Gerrit-HasComments: Yes
