Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15826 )
Change subject: IMPALA-9701: fix data race in BTS ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15826/1/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/15826/1/be/src/runtime/buffered-tuple-stream.cc@1082 PS1, Line 1082: // Only set 'attach_on_read' if needed. Otherwise this creates a benign nit: Only set 'attach_on_read' if needed (true only for single threaded built-in iterator mode) -- To view, visit http://gerrit.cloudera.org:8080/15826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2c4464adbc51bb8b0214ba0adbfa71217b87c86 Gerrit-Change-Number: 15826 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 28 Apr 2020 03:01:10 +0000 Gerrit-HasComments: Yes
