Hello Tim Armstrong, Joe McDonnell, Dinesh Garg, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15796
to look at the new patch set (#5).
Change subject: IMPALA-9649: Add shiro* to the banned dependency maven plugin
......................................................................
IMPALA-9649: Add shiro* to the banned dependency maven plugin
The earlier attempt to exclude the shiro-core and shiro-crypto-cipher jars
from fe/pom.xml failed to find all instances, and security scans picked
them up again. This patch also moves the shiro exclusions from the sentry
node to the dependencyManagement node, and excludes the jar from the
following:
- sentry-core-common
- sentry-provider-db
- sentry-provider-file
- sentry-provider-cache
Furthermore, to avoid compilation errors related to the absense of shiro, it
was necessary to remove the TestSentryResourceAuthorizationProvider class,
and any tests that referenced it. Since Sentry is not being used any longer,
this shouldn't be an issue.
Tested by running build, which didn't fail from banned dependency plugin,
as well running the standard set of tests on jenkins.impala.io.
Change-Id: I9f9994bf81c1d2e025a03925e8eccb147c34d66e
---
M fe/pom.xml
M fe/src/test/java/org/apache/impala/authorization/AuthorizationTest.java
D
fe/src/test/java/org/apache/impala/testutil/TestSentryResourceAuthorizationProvider.java
3 files changed, 61 insertions(+), 163 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/15796/5
--
To view, visit http://gerrit.cloudera.org:8080/15796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f9994bf81c1d2e025a03925e8eccb147c34d66e
Gerrit-Change-Number: 15796
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Dinesh Garg (430)
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
