Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/15816 )
Change subject: IMPALA-9680 Fixed compressed inserts failing ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/15816/3/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/15816/3/tests/common/custom_cluster_test_suite.py@69 PS3, Line 69: @classmethod : def add_test_dimensions(cls): : super(CustomClusterTestSuite, cls).add_test_dimensions() : cls.add_custom_cl > Why do we need this here if is already in ImpalaTestSuite? Done http://gerrit.cloudera.org:8080/#/c/15816/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/15816/3/tests/common/impala_test_suite.py@769 PS3, Line 769: return QueryTestSectionReader.get_db_name(table_format, scale_factor) : > nit: this fits to one line Done http://gerrit.cloudera.org:8080/#/c/15816/2/tests/custom_cluster/test_mt_dop.py File tests/custom_cluster/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/15816/2/tests/custom_cluster/test_mt_dop.py@38 PS2, Line 38: @CustomClusterTestSuite.with_args(impalad_args="--mt_dop_auto_fallback=true") > Ah, I see - but this is a CustomClusterTest, so it makes sense not to run i These tests are flaky if not run serially. for example, test_insert_large_string sometimes come back with an error that it can't allocate enough memory. -- To view, visit http://gerrit.cloudera.org:8080/15816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3c7ba02190f57a7ed40311c95a3dd9eca9b474d Gerrit-Change-Number: 15816 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 04 May 2020 08:49:58 +0000 Gerrit-HasComments: Yes
