Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. ...................................................................... Patch Set 1: (1 comment) I have pretty much copied what you suggested :-) http://gerrit.cloudera.org:8080/#/c/15752/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/15752/1/tests/shell/test_shell_interactive.py@88 PS1, Line 88: self.headers.headers > Sorry about the line wrapping. Thanks for the really useful review. The thing I had not understood was how useful it is to use a @pytest.yield_fixture even for a one-use situation. And they don't have to be in conftest.py -- To view, visit http://gerrit.cloudera.org:8080/15752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82996015d0205923e854dac8bb88604778684c46 Gerrit-Change-Number: 15752 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 05 May 2020 23:38:01 +0000 Gerrit-HasComments: Yes
