Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 )
Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes ...................................................................... Patch Set 21: Code-Review+1 (2 comments) This is looking good to me. http://gerrit.cloudera.org:8080/#/c/14824/21/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/14824/21/be/src/runtime/coordinator.cc@1071 PS21, Line 1071: transform(failed_backend_states.begin(), failed_backend_states.end(), : back_inserter(backend_addresses), [](BackendState* backend_state) -> string { : return TNetworkAddressToString(backend_state->krpc_impalad_address()); : }); Purely style nit: I think this would be cleaner as a for-loop. for (BackendState* backend_state : failed_backend_states) { backend_addresses.push_back(TNetworkAddressToString(...)); } http://gerrit.cloudera.org:8080/#/c/14824/21/be/src/runtime/coordinator.cc@1077 PS21, Line 1077: for_each(failed_backend_states.begin(), failed_backend_states.end(), : [&retryable_status](BackendState* backend_state) { : retryable_status.MergeStatus( : FromKuduStatus(backend_state->exec_rpc_status(), "Exec() rpc failed")); : }); Purely style nit: I think this would be cleaner as a for-loop: for (BackendState* backend_state : failed_backend_states) { retryable_status.MergeStatus(FromKuduStatus(...), ...); } -- To view, visit http://gerrit.cloudera.org:8080/14824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e4a0e72a9bf8ec10b91639aefd81bef17886ddd Gerrit-Change-Number: 14824 Gerrit-PatchSet: 21 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 06 May 2020 23:14:56 +0000 Gerrit-HasComments: Yes
