Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 14: (3 comments) Thanks for applying the changes! http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2544 PS14, Line 2544: //We need to set location here if not been specified in sql : org.apache.hadoop.hive.metastore.api.Database database = : msClient.getHiveClient().getDatabase(newTable.getDbName()); : location = database.getLocationUri() + : "/" + newTable.getTableName(); Might be safer to use MetastoreShim.getPathForNewTable() to avoid subtle bugs. Some context: Since Hive 3 only Hive ACID tables can be managed: https://issues.apache.org/jira/browse/HIVE-22158 To enforce this HMS translation layer converts managed non-ACID tables (in this case the Iceberg tables) to external tables. This might also change the table's location. http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@53 PS14, Line 53: tableName nit: tableLocation? http://gerrit.cloudera.org:8080/#/c/15797/14/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@62 PS14, Line 62: options nit: operations? -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 14 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Fri, 08 May 2020 17:48:42 +0000 Gerrit-HasComments: Yes
