Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15864 )
Change subject: IMPALA-7833 Audit and fix string builtins for long string handling ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Found a couple of nits, but other than that LGTM. http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/aggregate-functions-ir.cc@758 PS6, Line 758: "Concatenated string length larger than allowed limit of " : + PrettyPrinter::Print(StringVal::MAX_LENGTH, TUnit::BYTES) : + " character data.").c_str() > nit: Impala's convention is to use the Substitute() function from "gutil/st Also, the format string could be stored in a global constant, so you wouldn't repeat it multiple times. http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/15864/6/be/src/exprs/string-functions-ir.cc@172 PS6, Line 172: "rpad() result is larger than allowed limit of " nit: you could have a global format string like: "$0 result is larger than allowed limit of $1 character data." and you'd just pass 'space()/repeat()/lpad()/rpad()' and the limit to Substitute(). -- To view, visit http://gerrit.cloudera.org:8080/15864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93a53845f04e61ff446b363c78db1e49cbd5dc49 Gerrit-Change-Number: 15864 Gerrit-PatchSet: 6 Gerrit-Owner: Akos Kovacs <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 11 May 2020 14:23:06 +0000 Gerrit-HasComments: Yes
