Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15854 )
Change subject: IMPALA-9597: Eliminate redundant Ranger audits for column masking ...................................................................... Patch Set 7: Code-Review+1 (4 comments) LGTM. Leave some nits. http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@419 PS7, Line 419: TClientRequest clientRequest; : AuthorizationContext authzCtx = null; nit: merge these two lines into the following two lines. http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@444 PS7, Line 444: authzCtx != null nit: I think this is always true so we don't need this check. We can add an assertion for "authzCtx != null" after calling authzChecker.createAuthorizationContext(). http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java: http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationContext.java@55 PS7, Line 55: At this point, there are : * only column masking-related events on the List. nit: can we add an assertion for this? http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java: http://gerrit.cloudera.org:8080/#/c/15854/7/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java@353 PS7, Line 353: ," nit: need a space -- To view, visit http://gerrit.cloudera.org:8080/15854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42d60130fba93d63fbc36949f2bf746b7ae2497d Gerrit-Change-Number: 15854 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 13 May 2020 08:02:44 +0000 Gerrit-HasComments: Yes
