Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15904 )
Change subject: IMPALA-9725: incorrect spilling join results for wide keys ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Thanks for fixing this. We would probably have been hit by this with full ACID milestone 4 (LEFT ANTI HASH JOIN between deltas and delete deltas). http://gerrit.cloudera.org:8080/#/c/15904/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15904/2//COMMIT_MSG@22 PS2, Line 22: where where nit: double where http://gerrit.cloudera.org:8080/#/c/15904/2/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: http://gerrit.cloudera.org:8080/#/c/15904/2/be/src/exec/partitioned-hash-join-node-ir.cc@337 PS2, Line 337: NULL nit: nullptr? http://gerrit.cloudera.org:8080/#/c/15904/2/be/src/exec/partitioned-hash-join-node-ir.cc@390 PS2, Line 390: NULL nit: nullptr? -- To view, visit http://gerrit.cloudera.org:8080/15904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d7e5871c35a90e8cf24b8dded04775ee1eae9d8 Gerrit-Change-Number: 15904 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 14 May 2020 10:06:56 +0000 Gerrit-HasComments: Yes
