Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 )
Change subject: IMPALA-9669: Fix wrong table types for GET_TABLES in LocalCatalog ...................................................................... Patch Set 3: (2 comments) Revised the class comment. Working on propagating types and comments when loading table names. http://gerrit.cloudera.org:8080/#/c/15887/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15887/2//COMMIT_MSG@21 PS2, Line 21: his patch fixes : the problem by adding an additional lookup in the local cache for the : table meta (hmsTable) of each table when creating the : LocalIncompleteTables > If I understand correctly it is possible that if there are multiple coordin Good point! Load-balancers will cause the inconsistent results. I planned to propagate the types and comments with table names when fixing IMPALA-9670. I'll do this in the comming patch to fix the load-balancer issue. http://gerrit.cloudera.org:8080/#/c/15887/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/15887/2/fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java@30 PS2, Line 30: */ > nit, add a class comment which specifies that the LocalInCompleteTable coul Done -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 15 May 2020 02:08:16 +0000 Gerrit-HasComments: Yes
