Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15887 )
Change subject: IMPALA-9669: Fix wrong types/comments of loaded tables/views for GET_TABLES in LocalCatalog ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/15887/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15887/7//COMMIT_MSG@20 PS7, Line 20: This is fixed by loading table types and comments along with table names I guess we never had SYNC_DDL semantics for GET_TABLES, did we? I.e. a table load could trigger a change in the results of GET_TABLES, but we don't block waiting for that invalidation to be propagated to other impalads. I don't think we need to fix it, I just noticed this in the current code and wanted to confirm it was expected. http://gerrit.cloudera.org:8080/#/c/15887/7/fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/15887/7/fe/src/main/java/org/apache/impala/catalog/local/LocalIncompleteTable.java@31 PS7, Line 31: private final String msTableType; These can be null if it's partially loaded, right? -- To view, visit http://gerrit.cloudera.org:8080/15887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2180c603f061838347936f718cd4a0257d82e633 Gerrit-Change-Number: 15887 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 19 May 2020 17:29:01 +0000 Gerrit-HasComments: Yes
