Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15960 )

Change subject: IMPALA-9755: Flaky test: test_global_exchange_counters
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15960/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/15960/1/tests/query_test/test_observability.py@498
PS1, Line 498:     for line in profile.splitlines():
?? ?? ?? ??

Doing this on the text profile is pretty ugly, wish we'd built out some ways to 
do this in a more structure manner. I think this is OK though.



--
To view, visit http://gerrit.cloudera.org:8080/15960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb3a1b5ccb5695eb71343e96cc830f12d5c72f1e
Gerrit-Change-Number: 15960
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 23:54:45 +0000
Gerrit-HasComments: Yes

Reply via email to