Zoltan Garaguly has posted comments on this change. ( http://gerrit.cloudera.org:8080/15903 )
Change subject: IMPALA-8860: Improve /log_level usability on WebUI ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15903/6//COMMIT_MSG@9 PS6, Line 9: > nit: for log messages we use lines with 72 chars width. Done http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc File be/src/util/logging-support.cc: http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@143 PS6, Line 143: l > nit:extra space Done http://gerrit.cloudera.org:8080/#/c/15903/6/be/src/util/logging-support.cc@233 PS6, Line 233: if (display_log4j_handlers) {GetJavaLogLevels(doc);} : GetGlogLevel(doc); : }; > nit: fits single line as well Done http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift File common/thrift/Logging.thrift: http://gerrit.cloudera.org:8080/#/c/15903/6/common/thrift/Logging.thrift@48 PS6, Line 48: log_level > nit: we use underscores in member names, i.e. it should be log_levels Done -- To view, visit http://gerrit.cloudera.org:8080/15903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbf2ef21f4af297913a4e9b16a391768624da33 Gerrit-Change-Number: 15903 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Garaguly <zgarag...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Zoltan Garaguly <zgarag...@cloudera.com> Gerrit-Comment-Date: Wed, 20 May 2020 11:30:13 +0000 Gerrit-HasComments: Yes
