Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15987 )

Change subject: IMPALA-9743: ExprCardinalityTest should reset the test flag at 
the end of the test
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15987/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15987/2//COMMIT_MSG@7
PS2, Line 7:  at the
> nit: "at last" --> "at the end of the test"
Done


http://gerrit.cloudera.org:8080/#/c/15987/2//COMMIT_MSG@10
PS2, Line 10: at the
> same comment as above
Done


http://gerrit.cloudera.org:8080/#/c/15987/2//COMMIT_MSG@15
PS2, Line 15: explicitly. We'll gone through all tests to fix this in 
IMPALA-9780.
> mention what testing was done to validate this patch
Done



--
To view, visit http://gerrit.cloudera.org:8080/15987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a1085d73666db5df038dc231f14c31206375ed
Gerrit-Change-Number: 15987
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2020 15:06:09 +0000
Gerrit-HasComments: Yes

Reply via email to