Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15991
to look at the new patch set (#2).
Change subject: IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7
......................................................................
IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7
The locations for native packages in IMPALA_TOOLCHAIN currently
do not include the compiler version. This means that the
toolchain can't distinguish between native packages built
with gcc 4.9.2 versus gcc 7.5.0. The collisions can cause
issues when switching back and forth between branches.
This introduces the NATIVE_PACKAGES_HOME environment variable,
which is a location inside IMPALA_TOOLCHAIN that would hold
native packages. Currently, it is set to the same as
IMPALA_TOOLCHAIN, so there is no difference in behavior.
This lays the groundwork to add the compiler version to this
path when switching to GCC7.
Testing:
- Built with NATIVE_PACKAGES_HOME=$IMPALA_TOOLCHAIN/test
and verified that it will work with a path other than
$IMPALA_TOOLCHAIN.
- Core tests
Change-Id: I1ff641e503b2161baf415355452f86b6c8bfb15b
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/service/CMakeLists.txt
M bin/bootstrap_toolchain.py
M bin/distcc/distcc.sh
M bin/dump_breakpad_symbols.py
M bin/impala-config.sh
M bin/impala-shell.sh
M bin/jenkins/finalize.sh
M bin/run-backend-tests.sh
M bin/run-binary.sh
M bin/run-jvm-binary.sh
M bin/run_clang_tidy.sh
M bin/set-ld-library-path.sh
M bin/set-pythonpath.sh
M cmake_modules/clang_toolchain.cmake
M cmake_modules/toolchain.cmake
M docker/setup_build_context.py
M fe/pom.xml
M infra/python/bootstrap_virtualenv.py
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
M testdata/datasets/tpcds/preload
M testdata/datasets/tpch/preload
24 files changed, 91 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/15991/2
--
To view, visit http://gerrit.cloudera.org:8080/15991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ff641e503b2161baf415355452f86b6c8bfb15b
Gerrit-Change-Number: 15991
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
