Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 )
Change subject: IMPALA-9778: Refactor partition modifications in DDL/DMLs ...................................................................... Patch Set 10: (2 comments) The patch looks good to me. I mostly have some minor suggestions below. http://gerrit.cloudera.org:8080/#/c/15985/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/15985/10/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@629 PS10, Line 629: byte[] Does this need to be a immutable data structure as well? Can someone do this? hdfsPartition.getPartitionStatsCompressed()[1] = 0; http://gerrit.cloudera.org:8080/#/c/15985/12/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/15985/12/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@86 PS12, Line 86: HdfsPartition Would be great to document that this class is immutable and we should use HdfsPartition.Builder to create and replace partitions instead of updating the partitions in-place. -- To view, visit http://gerrit.cloudera.org:8080/15985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib52e5810d01d5e0c910daacb9c98977426d3914c Gerrit-Change-Number: 15985 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Jun 2020 00:18:10 +0000 Gerrit-HasComments: Yes
