Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15735 )
Change subject: IMPALA-9107 (part 2): Add script to use the m2 archive tarball ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/build-all-flag-combinations.sh File bin/jenkins/build-all-flag-combinations.sh: http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/build-all-flag-combinations.sh@65 PS6, Line 65: mkdir -p ${TMP_DIR} > nit: mktemp above will actually create the directory, so this is not necess Good point, removed http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/populate_m2_directory.py File bin/jenkins/populate_m2_directory.py: http://gerrit.cloudera.org:8080/#/c/15735/6/bin/jenkins/populate_m2_directory.py@25 PS6, Line 25: ALL_BUILD_OPTIONS_JOB = "all-build-options-ub1604" > The script would gain some flexibility if these constants were exposed as p I think I would like for us to add that only if when we need it. -- To view, visit http://gerrit.cloudera.org:8080/15735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5065658d8c0514550927161855b0943fa7b3a402 Gerrit-Change-Number: 15735 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Jun 2020 20:50:29 +0000 Gerrit-HasComments: Yes
