Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16080 )
Change subject: IMPALA-9858: Fix wrong partition metrics in LocalCatalog profile ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Thank Anurag for the quick review! Carry on the +2. http://gerrit.cloudera.org:8080/#/c/16080/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java File fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java: http://gerrit.cloudera.org:8080/#/c/16080/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@263 PS1, Line 263: // Load all partition ids. This will create a Partit > Nit: Change the line to "Load all partition ids. This will create a Partiti Done http://gerrit.cloudera.org:8080/#/c/16080/1/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@265 PS1, Line 265: // Load all partitions. This will create one par > Nit: Change the line to "Load all partitions. This will create one partitio Done -- To view, visit http://gerrit.cloudera.org:8080/16080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10cabce2908f1d252b90390978e679d31003e89d Gerrit-Change-Number: 16080 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Jun 2020 01:23:07 +0000 Gerrit-HasComments: Yes
