Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15797 )
Change subject: IMPALA-9688: Support create iceberg table by impala ...................................................................... Patch Set 22: (3 comments) http://gerrit.cloudera.org:8080/#/c/15797/21//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15797/21//COMMIT_MSG@18 PS21, Line 18: partition by spec( : level identity, : event_time identity, : event_time hour, : register_time day : ) > yes, presto supported create iceberg table: https://github.com/prestosql/pr I think its ok to use partitioned by spec for now. http://gerrit.cloudera.org:8080/#/c/15797/21/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/15797/21/fe/src/main/cup/sql-parser.cup@1607 PS21, Line 1607: createIcebergPartitionedLayout > Yes, you are right, when I use undefined iceberg partition transform in sql It looks like there are multiple transforms possible. I am not sure if users can implement their own transforms or not in Iceberg. Probably its just easier to change the exception type to ImpalaRunTimeException in the IcebergUtil.getPartitionTransform() method. http://gerrit.cloudera.org:8080/#/c/15797/21/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/15797/21/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@231 PS21, Line 231: for (PartitionField field : spec.fields()) { : fields.add(new IcebergPartitionField(field.sourceId(), field.fieldId(), : field.name(), IcebergUtil.getPartitionTransform(field))); : } > Iceberg not allowed partition column not exists in source column, so if sql ok thanks for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/15797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d85db4c904a8c758c4cfb4f19cfbdab7e6ea284 Gerrit-Change-Number: 15797 Gerrit-PatchSet: 22 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 17 Jun 2020 22:31:45 +0000 Gerrit-HasComments: Yes
