Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16096 )
Change subject: IMPALA-9569: Show progress bar and live_summary of the retried query ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16096/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16096/1/be/src/service/impala-server.cc@746 PS1, Line 746: if (query_handle->IsRetriedQuery()) { what happens if the above if condition is true? e.g. if 'query_handle->exec_state() == ClientRequestState::ExecState::PENDING' is true? should this code block be moved outside this if statement? http://gerrit.cloudera.org:8080/#/c/16096/1/be/src/service/impala-server.cc@749 PS1, Line 749: DCHECK(status.ok()) << "Original query handle not found!"; This might actually cause issues. Looking through this method, if GetQueryHandle returns a failure status, it looks through the 'completed query log' to search for the query instead rather than throwing an error. http://gerrit.cloudera.org:8080/#/c/16096/1/be/src/service/impala-server.cc@763 PS1, Line 763: // Look for the query in completed query log. somewhat related to this patch, what happens if you run a query in the impala-shell, it gets retried and completes successfully, and then the user runs the 'summary;' command? does it display the summary of the original query or the retried query? does it have any indication that the query is retried? since summaries are pretty small, we might be able to get do something like: localhost:21000] default> select 1; <for arguments sake lets sake this query got retried> [localhost:21000] default> summary; Query was retried. Original query id: <original-id>, Retried query id <retried-id> Original Summary: +----------+--------+-------+----------+----------+-------+------------+----------+---------------+--------+ | Operator | #Hosts | #Inst | Avg Time | Max Time | #Rows | Est. #Rows | Peak Mem | Est. Peak Mem | Detail | +----------+--------+-------+----------+----------+-------+------------+----------+---------------+--------+ | F00:ROOT | 1 | 1 | 14.57us | 14.57us | | | 0 B | 0 B | | | 00:UNION | 1 | 1 | 31.12us | 31.12us | 1 | 1 | 0 B | 0 B | | +----------+--------+-------+----------+----------+-------+------------+----------+---------------+--------+ Retried Summary: +----------+--------+-------+----------+----------+-------+------------+----------+---------------+--------+ | Operator | #Hosts | #Inst | Avg Time | Max Time | #Rows | Est. #Rows | Peak Mem | Est. Peak Mem | Detail | +----------+--------+-------+----------+----------+-------+------------+----------+---------------+--------+ | F00:ROOT | 1 | 1 | 14.57us | 14.57us | | | 0 B | 0 B | | | 00:UNION | 1 | 1 | 31.12us | 31.12us | 1 | 1 | 0 B | 0 B | | +----------+--------+-------+----------+----------+-------+------------+----------+---------------+--------+ This is slightly orthogonal to the goal of this patch so feel free to file a follow up JIRA on this and we can pursue it separately. -- To view, visit http://gerrit.cloudera.org:8080/16096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f96919f00e0b64d589efd15b6b5ec82fb725d56 Gerrit-Change-Number: 16096 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Jun 2020 17:10:09 +0000 Gerrit-HasComments: Yes
