Yida Wu has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/16083 )
Change subject: IMPALA-9829: Add Write Metrics for Spilling ...................................................................... IMPALA-9829: Add Write Metrics for Spilling Currently, we have read metrics for spilling, in this patch, we add support for write metrics. The new metrics could be useful to measure the write operations and target performance issues when involving in spilling to remote disks(S3) (IMPALA-9828). Three types of metrics are added in disk-io-mgr: 1. impala-server.io-mgr.queue-$0.write-latency, unit: ns, kind: HistogramMetric 2. impala-server.io-mgr.queue-$0.write-size, unit: Bytes, kind: HistogramMetric 3. impala-server.io-mgr.queue-$0.write-io-error, kind: IntCounter Write size, latency and io errors will be recorded in impala::io::DiskIoMgr::Write. Testing: * added DiskIoMgrTest.MetricsOfWriteSizeAndLatency * added DiskIoMgrTest.MetricsOfWriteIoError Ran unit test disk-io-mgr-test and pre-commit test Change-Id: I152b9c5339cedabe33f8873a2bbf651aa5dbb914 --- M be/src/runtime/io/disk-io-mgr-internal.h M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/disk-io-mgr.h M be/src/util/histogram-metric.h M common/thrift/metrics.json 6 files changed, 258 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/16083/11 -- To view, visit http://gerrit.cloudera.org:8080/16083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I152b9c5339cedabe33f8873a2bbf651aa5dbb914 Gerrit-Change-Number: 16083 Gerrit-PatchSet: 11 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
