Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15961 )

Change subject: IMPALA-9692 (part 3): Model QuerySchedule as a protobuf
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15961/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15961/6//COMMIT_MSG@42
PS6, Line 42: get
> Seems right to me?
Done


http://gerrit.cloudera.org:8080/#/c/15961/4/be/src/scheduling/query-schedule.h
File be/src/scheduling/query-schedule.h:

http://gerrit.cloudera.org:8080/#/c/15961/4/be/src/scheduling/query-schedule.h@58
PS4, Line 58: er
> Great, I'll do it in a follow up
JIRA?



--
To view, visit http://gerrit.cloudera.org:8080/15961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1db64e72f84604b1d8ac24e0bdd4ad6bedd6bcd9
Gerrit-Change-Number: 15961
Gerrit-PatchSet: 8
Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jun 2020 21:40:33 +0000
Gerrit-HasComments: Yes

Reply via email to