Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16093 )
Change subject: IMPALA-9213: Add query retry info to GetLog result ...................................................................... IMPALA-9213: Add query retry info to GetLog result Beeswax clients use get_log() to retrieve the warning/error message after the query finishes. HS2 clients use GetLog() for the same purpose. This patch adds the retry information into the returned result if the query is retried. So clients that print the log can show the original query failure and the retried query id. This patch also modifies impala-shell to extract the retried query id and print the retried query link. Here's an example of the impala-shell output: Query: select count(*) from functional.alltypes where bool_col = sleep(60) Query submitted at: 2020-06-18 21:23:52 (Coordinator: http://quanlong-OptiPlex-BJ:25000) Query progress can be monitored at: http://quanlong-OptiPlex-BJ:25000/query_plan?query_id=7944ffee4d81cdd4:e7f9357a00000000 +----------+ | count(*) | +----------+ | 3650 | +----------+ WARNINGS: Original query failed: Failed due to unreachable impalad(s): quanlong-OptiPlex-BJ:22001 Query has been retried using query id: 934b2734f67a1161:a0dbd60200000000 Retried query link: http://quanlong-OptiPlex-BJ:25000/query_plan?query_id=934b2734f67a1161:a0dbd60200000000 Tests: - Add tests in test_query_retries.py to verify client logs returned from GetLog(). - Run test_query_retries.py. - Manually run queries in impala-shell and kill impalads. Verify printed messages when the retried queries succeed or fail. Change-Id: I58cf94f91a0b92eb9a3088bee3894ac157a954dc Reviewed-on: http://gerrit.cloudera.org:8080/16093 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M shell/impala_client.py M shell/impala_shell.py M tests/custom_cluster/test_query_retries.py 7 files changed, 96 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I58cf94f91a0b92eb9a3088bee3894ac157a954dc Gerrit-Change-Number: 16093 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>