Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16112 )
Change subject: IMPALA-9897: GROUPING SETS/CUBE/ROLLUP parsing and analysis ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/16112/10/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/16112/10/fe/src/main/cup/sql-parser.cup@3076 PS10, Line 3076: // * GROUP BY a, b, c WITH CUBE - non-standard CUBE syntax supported by some systems > Add example of GROUP BY GROUPING SETS ? Done http://gerrit.cloudera.org:8080/#/c/16112/10/fe/src/main/cup/sql-parser.cup@3076 PS10, Line 3076: // * GROUP BY a, b, c WITH CUBE - non-standard CUBE syntax supported by some systems > Add example of GROUP BY GROUPING SETS ? Done http://gerrit.cloudera.org:8080/#/c/16112/10/fe/src/main/java/org/apache/impala/analysis/GroupByClause.java File fe/src/main/java/org/apache/impala/analysis/GroupByClause.java: http://gerrit.cloudera.org:8080/#/c/16112/10/fe/src/main/java/org/apache/impala/analysis/GroupByClause.java@121 PS10, Line 121: private void addGroupingID(long id, List<Expr> groupingExprs) throws AnalysisException { > Nit but might be cleaner to use the JDK BitSet class especially down the li It's probably easier to leave as-is, if only because enumerating classes for CUBE is way more concise using additional on an integer. I added some comments to explain that bit manipulation logic to make it less cryptic. -- To view, visit http://gerrit.cloudera.org:8080/16112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I178e45de94d736630c97ae1ec4a92423cd74621f Gerrit-Change-Number: 16112 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jun 2020 21:03:21 +0000 Gerrit-HasComments: Yes
