Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 )
Change subject: WIP - IMPALA-9898: generate grouping set plans ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/16128/6/fe/src/main/java/org/apache/impala/analysis/GroupByClause.java File fe/src/main/java/org/apache/impala/analysis/GroupByClause.java: http://gerrit.cloudera.org:8080/#/c/16128/6/fe/src/main/java/org/apache/impala/analysis/GroupByClause.java@137 PS6, Line 137: private void addGroupingID(long id, List<Expr> groupingExprs, List<Expr> addtlGroupingExprs) line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16128/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/16128/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@2472 PS6, Line 2472: AnalysisError("select distinct int_col, bool_col, count(*) from functional.alltypes " + line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie454c5bf7aee266321dee615548d7f2b71380197 Gerrit-Change-Number: 16128 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Jul 2020 03:57:58 +0000 Gerrit-HasComments: Yes
