Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16131 )
Change subject: IMPALA-9911: Fix IS [NOT] NULL predicate selectivity ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16131/2/fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java File fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/16131/2/fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java@415 PS2, Line 415: verifySelectExpr("alltypes", "int_col is null", 3, 0); I think the NDV bug is still a thing right (I guess it's not too consequential). http://gerrit.cloudera.org:8080/#/c/16131/2/fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java@446 PS2, Line 446: Same here. -- To view, visit http://gerrit.cloudera.org:8080/16131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c084be780b8f5aead9e2b9656fbab6cc8c8874 Gerrit-Change-Number: 16131 Gerrit-PatchSet: 4 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Jul 2020 04:53:42 +0000 Gerrit-HasComments: Yes
