Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 )
Change subject: IMPALA-9898: generate grouping set plans ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16128/8/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/16128/8/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@354 PS8, Line 354: info that may be created by an external planner > I did not update this comment in my patch. It would be good if you can. Y Done http://gerrit.cloudera.org:8080/#/c/16128/8/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@479 PS8, Line 479: * Currently, Impala does not support ROLLUP directly but suppose an external planner > Same here. Remove this statement and re-word it to something like 'caller Done -- To view, visit http://gerrit.cloudera.org:8080/16128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie454c5bf7aee266321dee615548d7f2b71380197 Gerrit-Change-Number: 16128 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Jul 2020 18:57:13 +0000 Gerrit-HasComments: Yes
