Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 )
Change subject: IMPALA-9917: grouping() and grouping_id() support ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/16140/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16140/3//COMMIT_MSG@31 PS3, Line 31: Also TPC-DS planner tests. http://gerrit.cloudera.org:8080/#/c/16140/6/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/16140/6/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@399 PS6, Line 399: aggExpr.getFnName().getFunction() + "' must be combined with multiple " + > line too long (100 > 90) Done http://gerrit.cloudera.org:8080/#/c/16140/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/16140/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3750 PS6, Line 3750: ParsesOk("SELECT a, grouping(a) as `grouping` FROM foo " + > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/16140/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3751 PS6, Line 3751: "GROUP BY GROUPING SETS((a, b))"); > line too long (93 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/16140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0b1640d606256c0fe9204d2a21a8f6d06abcdb6 Gerrit-Change-Number: 16140 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Jul 2020 23:58:24 +0000 Gerrit-HasComments: Yes
