Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 )
Change subject: IMPALA-9917: grouping() and grouping_id() support ...................................................................... Patch Set 10: Code-Review+1 (2 comments) LGTM. http://gerrit.cloudera.org:8080/#/c/16140/10/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/16140/10/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@309 PS10, Line 309: aggInfos_.get(0).getResultSmap() : new ExprSubstitutionMap(); Should this also clone() the smap like in the 'if' case ? If so, this assignment is common to both if-else and can be moved out. http://gerrit.cloudera.org:8080/#/c/16140/10/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@328 PS10, Line 328: // all aggregation classes to he final output produced by the transposing aggregation. nit: 'he'->'the' -- To view, visit http://gerrit.cloudera.org:8080/16140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0b1640d606256c0fe9204d2a21a8f6d06abcdb6 Gerrit-Change-Number: 16140 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Jul 2020 20:02:12 +0000 Gerrit-HasComments: Yes
