Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16103 )
Change subject: IMPALA-9294: Support DATE for min-max runtime filter ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/16103/3/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test File testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test: http://gerrit.cloudera.org:8080/#/c/16103/3/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@168 PS3, Line 168: functional_kudu.date_tbl a : join [BROADCAST] functional_kudu.date_tbl b > While its a little hard to tell and I think that we do have a test that tec Will add a functional-query test as suggested http://gerrit.cloudera.org:8080/#/c/16103/7/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test File testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test: http://gerrit.cloudera.org:8080/#/c/16103/7/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@167 PS7, Line 167: # Query with date-typed join column > I think this case can be left out - its only showing that we'll generate DA will remove it http://gerrit.cloudera.org:8080/#/c/16103/7/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@206 PS7, Line 206: # Query with 3-way shuffer joins on date-typed join columns > I think its reasonable to leave this case in as we don't already have a pla Will update comments and change the type of one joined columns http://gerrit.cloudera.org:8080/#/c/16103/7/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@256 PS7, Line 256: # Query with 3-way join on date-typed join columns > I don't think this case is testing anything different from the existing cas will remove it http://gerrit.cloudera.org:8080/#/c/16103/7/testdata/workloads/functional-planner/queries/PlannerTest/min-max-runtime-filters.test@312 PS7, Line 312: # Query with 3-way join on date-typed and int-typed join columns > Same as above, I don't think this case is testing anything different from t Will remove it. -- To view, visit http://gerrit.cloudera.org:8080/16103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f6e2dc6949735d5f0fcf317361cc2969a5e82c Gerrit-Change-Number: 16103 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Jul 2020 00:46:44 +0000 Gerrit-HasComments: Yes
