Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 )
Change subject: IMPALA-9898: generate grouping set plans ...................................................................... Patch Set 11: (1 comment) An update on the comment. http://gerrit.cloudera.org:8080/#/c/16128/11/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: http://gerrit.cloudera.org:8080/#/c/16128/11/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test@3567 PS11, Line 3567: group by: id, int_col, bool_col, b.tinyint_col, b.string_col : | | Class 1 : | | group by: id, int_col, NULL, b.tinyint_col, b.string_col : | | Class 2 : | | group by: id, NULL, NULL, b.tinyint_col, b.string_col : | | Class 3 : | | group by: NULL, NULL, NULL, b.tinyint_col, b.string_col > If b.tinyint_col and string_col are low in selectivity against a.tinyint_co The first GROUPBY probably is not necessary as it will hide the rows needed to compute the Rollup group by. Here is the updated version. 1. hashjoin(a,b) on (tinyint_col, string_col). The output is b(id, int_col, bool_col). 2. Rollup groupby on (id, int_col, bool_col) from the join output. -- To view, visit http://gerrit.cloudera.org:8080/16128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie454c5bf7aee266321dee615548d7f2b71380197 Gerrit-Change-Number: 16128 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Jul 2020 15:56:15 +0000 Gerrit-HasComments: Yes
