wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 )
Change subject: IMPALA-9741: Support querying Iceberg table by impala ...................................................................... Patch Set 16: (6 comments) Hi Zoltan, I've already modify code and release patch to the latest commit. I will submit a Jenkins test again to ensure everything right. http://gerrit.cloudera.org:8080/#/c/16143/15/fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java File fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java: http://gerrit.cloudera.org:8080/#/c/16143/15/fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java@66 PS15, Line 66: we also cannot truncate Iceberg > nit: "we also cannot truncate Iceberg tables." Done http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/data/README@503 PS15, Line 503: t has s > nit: Iceberg Done http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/data/README@507 PS15, Line 507: > managed Done http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/data/README@508 PS15, Line 508: > nit: which contains the data files. Done http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@19 PS15, Line 19: AnalysisException: Cannot find source column: event_time : ==== > Can we catch this error during analysis, and throw an AnalysisException ins Done This exception throws from iceberg, I didn't check this in impala. Since you have mentioned this question, I add checkPartitionColumns in CreateTableStmt.java for iceberg managed table. http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-profile.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-profile.test: http://gerrit.cloudera.org:8080/#/c/16143/15/testdata/workloads/functional-query/queries/QueryTest/iceberg-profile.test@7 PS15, Line 7: aggregation(SUM, RowsRead): 6 : ==== > I'm just wondering how deterministic is it. Do the test consistently pass i Done use 'aggregation(SUM, RowsRead)' to replace 'row_regex: .* PARQUET/GZIP' -- To view, visit http://gerrit.cloudera.org:8080/16143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I856cfee4f3397d1a89cf17650e8d4fbfe1f2b006 Gerrit-Change-Number: 16143 Gerrit-PatchSet: 16 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2020 06:42:50 +0000 Gerrit-HasComments: Yes
