Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16238 )
Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.4 ...................................................................... Patch Set 5: (3 comments) just a few nits http://gerrit.cloudera.org:8080/#/c/16238/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16238/5//COMMIT_MSG@8 PS5, Line 8: 20.4 nit: its 20.04 and 18.04 http://gerrit.cloudera.org:8080/#/c/16238/5//COMMIT_MSG@13 PS5, Line 13: maching nit: typo http://gerrit.cloudera.org:8080/#/c/16238/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/16238/5/bin/bootstrap_system.sh@241 PS5, Line 241: or nit: should be "and" instead of "or", and should change "install" back to "installs". I think sentence is basically saying that by default Ubuntu 18.04 and 20.04 have OpenJDK 11 installed. -- To view, visit http://gerrit.cloudera.org:8080/16238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f592f60881fd8f34e2bf393a76f5a921505010a Gerrit-Change-Number: 16238 Gerrit-PatchSet: 5 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 25 Jul 2020 00:58:44 +0000 Gerrit-HasComments: Yes
