Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16254 )
Change subject: IMPALA-10024: isBlackListedDb() should do a case-insensitive check ...................................................................... IMPALA-10024: isBlackListedDb() should do a case-insensitive check The util method CatalogServiceCatalog#isBlackListedDb() expects the input dbName to be in lower-case which could be error-prone. Specifically, this can cause issues when Metastore event which has dbName which is in a different case than one configured in --blacklisted_dbs. In such cases the EventsProcessor does not ignore the event and can go into error state. The fix modifies the isBlackListedDb method to do a case-insensitive comparision. The isBlacklistedTable is not affected by this issue since TableName has built-in mechanism to ignore the case. Testing Done: 1. Modified the test_event_processing.py such that event generated has a different case than what is configured in --blacklisted_dbs. The updated test works after the patch. 2. Ran existing tests for events processor. Change-Id: I3898a46b4236413b2e328cecbb2f4364082a5e41 --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M tests/custom_cluster/test_event_processing.py 3 files changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/16254/4 -- To view, visit http://gerrit.cloudera.org:8080/16254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3898a46b4236413b2e328cecbb2f4364082a5e41 Gerrit-Change-Number: 16254 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
