Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 )
Change subject: WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16240/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16240/5//COMMIT_MSG@17 PS5, Line 17: To be specific, we save extra reservation for writing a large page. It's I'll need to look in more detail but I think the overal approach makes sense. http://gerrit.cloudera.org:8080/#/c/16240/5//COMMIT_MSG@35 PS5, Line 35: This patch also fixes the wrong assumption that non-streaming Maybe I missed something when I initially did this, but I didn't think we need to be able to fit all the hash tables in memory because we could repartition until we can fit a single partition in memory. I think this change is probably fine anyway, to avoid repartitioning, because the increase in reservation is very small. -- To view, visit http://gerrit.cloudera.org:8080/16240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d9c3a2e7f0da60071b920dec979729e86459775 Gerrit-Change-Number: 16240 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Aug 2020 16:52:20 +0000 Gerrit-HasComments: Yes
