Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 )
Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries ...................................................................... Patch Set 3: Code-Review+1 (2 comments) This makes sense to me. I can't think of any reason not to strip the debug symbols here, and it's great to save the space. http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py File docker/setup_build_context.py: http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py@87 PS3, Line 87: .py > Do we need to spell "-gdb.py" out here? I'm fine with excluding all the python files from this GCC directory. I don't expect us to need any. http://gerrit.cloudera.org:8080/#/c/16263/3/docker/setup_build_context.py@91 PS3, Line 91: check_call([STRIP, "--strip-debug", libstdcpp_so, "-o", : os.path.join(LIB_DIR, os.path.basename(libstdcpp_so))]) Nit: I think it would be good to factor out this strip call into a function similar to symlink_file_into_dir(). -- To view, visit http://gerrit.cloudera.org:8080/16263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61fdf47041bd96248ecb48ae57dde143de2da294 Gerrit-Change-Number: 16263 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Aug 2020 21:51:03 +0000 Gerrit-HasComments: Yes
