Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16259 )
Change subject: IMPALA-9963: Implement ds_kll_n() function ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16259/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16259/1//COMMIT_MSG@9 PS1, Line 9: > I think this should be in singular. Done http://gerrit.cloudera.org:8080/#/c/16259/4/be/src/exprs/datasketches-functions-ir.cc File be/src/exprs/datasketches-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16259/4/be/src/exprs/datasketches-functions-ir.cc@70 PS4, Line 70: return sketch.get_n(); > A try-catch block could be added to be sure. get_n() doesn't throw, it simply returns a member variable. https://github.com/apache/impala/blob/master/be/src/thirdparty/datasketches/kll_sketch_impl.hpp#L232 -- To view, visit http://gerrit.cloudera.org:8080/16259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781 Gerrit-Change-Number: 16259 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Aug 2020 06:11:08 +0000 Gerrit-HasComments: Yes
