Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 )
Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) ...................................................................... Patch Set 6: (1 comment) > Patch Set 4: > > (6 comments) http://gerrit.cloudera.org:8080/#/c/16228/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/16228/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@1508 PS3, Line 1508: * > Complex types are evaluated in a subplan, like the following: Thanks Zoltan. Just to clarify further...the plans I see in our test suites, for example tpch-nested.test are like the one above, but those tests already contain a nested collection in the FROM clause, so that gets Unnested as part of the SubPlan. If we take the ACID table case and we are projecting the ITEM expr, what would the plan look like ? For example, consider this query: SELECT o.item, t.c_custkey from tpch_nested_parquet.customer t left outer join t.c_orders o Will this involve two SubPlans or one ? -- To view, visit http://gerrit.cloudera.org:8080/16228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b2c6cd3d87c452c5b96a913b14c90ada78d4c6f Gerrit-Change-Number: 16228 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Aug 2020 06:26:41 +0000 Gerrit-HasComments: Yes
