Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 )
Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans ...................................................................... Patch Set 25: (1 comment) http://gerrit.cloudera.org:8080/#/c/16098/25/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16098/25/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1199 PS25, Line 1199: hasCorruptTableStats_ > Tables and partitions form a hierarchy and if the table has a valid RC (as in > this case through ALTER TABLE), then the table does not have missing stats, > regardless of the situations at the partition level. Agree, but again I don't understand how that is a reason to only trigger the if condition if stats are corrupt, but not if stats are missing. > Maybe this is a good comprise such that the intention to set RC at the table > level is preserved? Again agree, it is nice to preserve the intention of setting the RC at the table level, but again if the goal is preserve the setting of the table level RC, why does it matter is partition starts are missing vs. corrupt. -- To view, visit http://gerrit.cloudera.org:8080/16098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f4c64616ff7c0b6d5a48f2b5331325feeff3576 Gerrit-Change-Number: 16098 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Aug 2020 17:04:44 +0000 Gerrit-HasComments: Yes
