Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16331 )
Change subject: WIP IMPALA-7779 Parquet Scanner can write binary data into profile ...................................................................... Patch Set 1: (1 comment) overall, looks correct. would be nice to have a test for this as well. http://gerrit.cloudera.org:8080/#/c/16331/1/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16331/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@1337 PS1, Line 1337: char hex[2 * sizeof(PARQUET_VERSION_NUMBER) + 2]; : hex[0] = '0'; : hex[1] = 'x'; : auto hex_ptr = hex + 2; : for (int i = 0; i < sizeof(PARQUET_VERSION_NUMBER); i++) { : sprintf(hex_ptr + i * 2, "%02x", magic_number_ptr[i]); : } : return Status(TErrorCode::PARQUET_BAD_VERSION_NUMBER, filename(), : string(hex, sizeof(hex)), scan_node_->hdfs_table()->fully_qualified_name()); you can just use "ReadWriteUtil::HexDump" - we do something very similar in HdfsAvroScanner::ReadFileHeader -- To view, visit http://gerrit.cloudera.org:8080/16331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281d6fa7cb2f88f04588110943e3e768678b9cf1 Gerrit-Change-Number: 16331 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Aug 2020 21:27:39 +0000 Gerrit-HasComments: Yes
