Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 )
Change subject: IMPALA-9989 Improve admission control pool stats logging ...................................................................... Patch Set 36: (4 comments) http://gerrit.cloudera.org:8080/#/c/16220/34/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/16220/34/be/src/runtime/mem-tracker.cc@461 PS34, Line 461: heavMemoryQuery.__set_queryId(tracker->query_id_); > nit: can you print the mem-tracker->label here so thats its easy to debug i can you address this too http://gerrit.cloudera.org:8080/#/c/16220/36/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/16220/36/be/src/scheduling/admission-controller.h@640 PS36, Line 640: friend class MemTracker; why do we need to add this as a friend class? http://gerrit.cloudera.org:8080/#/c/16220/36/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16220/36/be/src/scheduling/admission-controller.cc@1626 PS36, Line 1626: << " Details:" << queue_node->not_admitted_details; see comment in generate_error_codes.py http://gerrit.cloudera.org:8080/#/c/16220/36/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: http://gerrit.cloudera.org:8080/#/c/16220/36/common/thrift/generate_error_codes.py@337 PS36, Line 337: Details: nit: details might not exist. So can get confusing if its left empty. You can probably just add $3 and append an empty string if it doesnt exist. -- To view, visit http://gerrit.cloudera.org:8080/16220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id995a9d044082c3b8f044e1ec25bb4c64347f781 Gerrit-Change-Number: 16220 Gerrit-PatchSet: 36 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Aug 2020 18:48:51 +0000 Gerrit-HasComments: Yes