Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15798 )
Change subject: IMPALA-9382: part 1: transposed profile prototype ...................................................................... Patch Set 16: (3 comments) I made it through most of the runtime-profile.h. The transformation of the averaged profile to the aggregated profile and resulting class hierarchy seems reasonable to me. http://gerrit.cloudera.org:8080/#/c/15798/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15798/16//COMMIT_MSG@30 PS16, Line 30: with RuntimeProfile and AggregatedRuntimeProfile : base classes "base classes" -> "subclasses"? http://gerrit.cloudera.org:8080/#/c/15798/16//COMMIT_MSG@44 PS16, Line 44: These stats can now be : automatically as aggregations of counters. Some words seem to be missing. http://gerrit.cloudera.org:8080/#/c/15798/16/common/thrift/RuntimeProfile.thrift File common/thrift/RuntimeProfile.thrift: http://gerrit.cloudera.org:8080/#/c/15798/16/common/thrift/RuntimeProfile.thrift@249 PS16, Line 249: an averaged profile : // for the fragment is also included with averaged counter values. Does the thrift for V1's average profile now also contain the TAggregatedRuntimeProfileNode struct? If so, are there any size concerns? -- To view, visit http://gerrit.cloudera.org:8080/15798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0838c6a0872f57c696267ff4e92d29c08748eb7a Gerrit-Change-Number: 15798 Gerrit-PatchSet: 16 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 15 Aug 2020 00:44:59 +0000 Gerrit-HasComments: Yes
