Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 )
Change subject: IMPALA-7658: Proper codegen for HiveUdfCall ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/16314/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16314/8//COMMIT_MSG@11 PS8, Line 11: TODO: Testing I believe we should be covering all the data types and codegen enabled/disabled with test_udf.py but you could double-check. http://gerrit.cloudera.org:8080/#/c/16314/8//COMMIT_MSG@31 PS8, Line 31: This is a ~7.8% improvement. Nice http://gerrit.cloudera.org:8080/#/c/16314/8/be/src/exprs/hive-udf-call.h File be/src/exprs/hive-udf-call.h: http://gerrit.cloudera.org:8080/#/c/16314/8/be/src/exprs/hive-udf-call.h@146 PS8, Line 146: : executor(nullptr), nit: initialise these inline where the initial values are constant -it's more concise and readable. http://gerrit.cloudera.org:8080/#/c/16314/8/be/src/exprs/hive-udf-call.h@153 PS8, Line 153: funxtions nit:functions http://gerrit.cloudera.org:8080/#/c/16314/8/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/16314/8/be/src/exprs/hive-udf-call.cc@179 PS8, Line 179: Chache Cache http://gerrit.cloudera.org:8080/#/c/16314/8/be/src/exprs/hive-udf-call.cc@278 PS8, Line 278: std::size_t GetMemcpySize(const PrimitiveType type) { I think this should return int64_t, since that's what we generally use for byte sizes Maybe this should be in codegen-util.h? -- To view, visit http://gerrit.cloudera.org:8080/16314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f994dac550f297ed3c88491816403f237d4d747 Gerrit-Change-Number: 16314 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 24 Aug 2020 21:03:10 +0000 Gerrit-HasComments: Yes
