Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 )
Change subject: IMPALA-10106: Update DataSketches ...................................................................... Patch Set 2: (2 comments) I did some research and it seems that the 2.1.0 release is not out and only in the voting phase of the release process. Please check the dev@ mail list for more details: http://mail-archives.apache.org/mod_mbox/datasketches-dev/202008.mbox/browser http://gerrit.cloudera.org:8080/#/c/16360/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16360/2//COMMIT_MSG@7 PS2, Line 7: Update DataSketches could you be more specific in the title of the commit message? You can add where do you plan to upgrade the library to. nit: I'd use the word 'upgrade' instead of 'update' http://gerrit.cloudera.org:8080/#/c/16360/2/be/src/thirdparty/datasketches/README.md File be/src/thirdparty/datasketches/README.md: http://gerrit.cloudera.org:8080/#/c/16360/2/be/src/thirdparty/datasketches/README.md@11 PS2, Line 11: 2.1.x-incubating As far as I know branches ending with ".x" are not final and they can still receive commits. AFAIK this is just a branch that will be used for releasing but not the release itself. E.g. 2.1.0 might have been created from this branch but later 2.1.1 will also be created from this once a number of commits are merged here. I found a git tag for 2.1.0-incubating, I think that is the one we'd like to go for and then we can say that we have the 2.1.0 version of DataSketches under Impala. -- To view, visit http://gerrit.cloudera.org:8080/16360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4faa31c0b628a62c7e56a6c4b9549d0aaa8a02ff Gerrit-Change-Number: 16360 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Aug 2020 12:45:17 +0000 Gerrit-HasComments: Yes
