Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: IMPALA-9482 Support for BINARY columns ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/16066/7/be/src/exec/text-converter.cc File be/src/exec/text-converter.cc: http://gerrit.cloudera.org:8080/#/c/16066/7/be/src/exec/text-converter.cc@355 PS7, Line 355: switch (col_type.type) { : case TYPE_CHAR: : return false; : case TYPE_STRING: : return auxType.string_subtype != AuxColumnType::StringSubtype::BINARY; : default: : return true; This could be simplified a bit in my opinion: if (col_type.type == TYPE_STRING) return auxType... != BINARY; return col_type.type != TYPE_CHAR; http://gerrit.cloudera.org:8080/#/c/16066/7/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16066/7/be/src/exprs/utility-functions-ir.cc@209 PS7, Line 209: const StringVal& /*input_val*/ Is this part needed? -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Aug 2020 09:20:16 +0000 Gerrit-HasComments: Yes
