Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/16314 )
Change subject: IMPALA-7658: Proper codegen for HiveUdfCall ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/16314/12/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: http://gerrit.cloudera.org:8080/#/c/16314/12/be/src/exprs/hive-udf-call.cc@292 PS12, Line 292: builder->CreateCondBr(child_wrapped.GetIsNull("child_is_null"), In the interpreted code, NULL-ness is determined based on the value of 'eval->GetValue(*GetChild(i), row);'. This is almost the same as calling '.GetIsNull' but in the case of Date, 'eval->GetValue' also contains a validity check. Date is not supported for Java UDFs either, so this shouldn't make a difference now but if/when we start supporting Date it may be a problem. Also, keeping codegen code and interpreted code similar is a good idea in my opinion. I think it's better to cross-compile eval->GetValue and use that in codegen. Do you agree? -- To view, visit http://gerrit.cloudera.org:8080/16314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f994dac550f297ed3c88491816403f237d4d747 Gerrit-Change-Number: 16314 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Aug 2020 09:55:19 +0000 Gerrit-HasComments: Yes
