Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16370 )
Change subject: IMPALA-10108: Implement ds_kll_stringify function ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16370/4/be/src/exprs/datasketches-functions.h File be/src/exprs/datasketches-functions.h: http://gerrit.cloudera.org:8080/#/c/16370/4/be/src/exprs/datasketches-functions.h@98 PS4, Line 98: FunctionContext* ctx nit: this fits in the previous line. http://gerrit.cloudera.org:8080/#/c/16370/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test: http://gerrit.cloudera.org:8080/#/c/16370/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test@604 PS3, Line 604: row_regex: .*### KLL sketch summary:.*Epsilon.*Epsilon PMF.*Em > An alternative would look like for the whole summary: Thx! -- To view, visit http://gerrit.cloudera.org:8080/16370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97f654a4838bf91e3e0bed6a00d78b2c7aa96f75 Gerrit-Change-Number: 16370 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Tamas <[email protected]> Gerrit-Reviewer: Adam Tamas <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2020 20:48:04 +0000 Gerrit-HasComments: Yes
