Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 )
Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images ...................................................................... Patch Set 2: (1 comment) The code changes basically look good. Let me know how testing goes, I can approve it then. http://gerrit.cloudera.org:8080/#/c/16320/2/docker/impalad_coord_exec/Dockerfile File docker/impalad_coord_exec/Dockerfile: PS2: > I removed the Dockerfile for the impalad_coord_exec and replaced it with a Is docker smart enough to deduplicate these by caching the previous build? I think we might need to override the flags in start-impala-cluster.py change since I think the script assumes that the is_coordinator and is_executor flags are both set in the container. TBH I think setting the flags in the dockerfiles may have been a mistake, since most frameworks, like k8s, ignores the command line anyway. -- To view, visit http://gerrit.cloudera.org:8080/16320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I899859a38d8ccab890de889a49ef132a89289dfd Gerrit-Change-Number: 16320 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 29 Aug 2020 00:28:13 +0000 Gerrit-HasComments: Yes
