Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16385 )
Change subject: IMPALA-9792: Implement splitting kudu scan ranges for greater parallelism ...................................................................... Patch Set 1: (4 comments) Awesome! I am super interested to see the performance impact of this change. http://gerrit.cloudera.org:8080/#/c/16385/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16385/1//COMMIT_MSG@15 PS1, Line 15: TARGETED_KUDU_SCAN_RANGE_LENGTH nit can you add the default chosen to the commit message here. http://gerrit.cloudera.org:8080/#/c/16385/1//COMMIT_MSG@24 PS1, Line 24: Testing Did you do any performance testing to gauge the impact (good or bad)? http://gerrit.cloudera.org:8080/#/c/16385/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/16385/1/be/src/service/query-options.h@a50 PS1, Line 50: Was this change an accident? http://gerrit.cloudera.org:8080/#/c/16385/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/16385/1/common/thrift/ImpalaService.thrift@574 PS1, Line 574: mt_dop >= 2 nit: "mt_dop > 1" to simplify and to match the commit message. -- To view, visit http://gerrit.cloudera.org:8080/16385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02fd94cc1d13c61bc6cb0765dd2cbe90e9a5ce8 Gerrit-Change-Number: 16385 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 31 Aug 2020 13:31:27 +0000 Gerrit-HasComments: Yes
